Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-30 - Move phpmd config to phpmd.xml. #234

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

raylwalters
Copy link
Contributor

User story: DEV-30: Move phpmd config into phpmd.xml

Description

This moves the phpmd config in to a separate phpmd.xml file.

Testing instructions

  1. Update the build for this branch in a project
  2. Run the build installer vendor/bin/the-build-installer
  3. Run code review vendor/bin/phing test to verify that phpmd runs.

@becw
Copy link
Member

becw commented Mar 20, 2024

When we move defaults/standard/phpmd.xml to defaults/install/phpmd.xml, we'll need to make sure to note this in the update steps. We should also consider bumping by a minor version (rather than a patch version) when we release this change.

Copy link
Contributor

@jaymejohnson jaymejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaymejohnson jaymejohnson merged commit ace5eaf into develop Jul 17, 2024
1 check passed
@jaymejohnson jaymejohnson deleted the DEV-30-phpmd-config branch July 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants